From 9d5cbcdd77124633274856f20d86b4749be41879 Mon Sep 17 00:00:00 2001 From: thecosmos Date: Sun, 26 May 2019 10:56:15 +0530 Subject: [PATCH] Use caps keys to store discord secrets in flask session object --- flask_discord/__init__.py | 2 +- flask_discord/_http.py | 6 +++--- flask_discord/client.py | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/flask_discord/__init__.py b/flask_discord/__init__.py index 997bc2b..49a652b 100644 --- a/flask_discord/__init__.py +++ b/flask_discord/__init__.py @@ -11,4 +11,4 @@ __all__ = [ ] -__version__ = "0.1.01" +__version__ = "0.1.02" diff --git a/flask_discord/_http.py b/flask_discord/_http.py index ba981bb..a96d9ca 100644 --- a/flask_discord/_http.py +++ b/flask_discord/_http.py @@ -25,8 +25,8 @@ class DiscordOAuth2HttpClient(abc.ABC): """ SESSION_KEYS = [ - "discord_oauth2_state", - "discord_oauth2_token", + "DISCORD_OAUTH2_STATE", + "DISCORD_OAUTH2_TOKEN", ] def __init__(self, app): @@ -38,7 +38,7 @@ class DiscordOAuth2HttpClient(abc.ABC): @staticmethod def _token_updater(token): - session["discord_oauth2_token"] = token + session["DISCORD_OAUTH2_TOKEN"] = token def _make_session(self, token: str = None, state: str = None, scope: list = None) -> OAuth2Session: """A low level method used for creating OAuth2 session. diff --git a/flask_discord/client.py b/flask_discord/client.py index b40d32e..0842098 100644 --- a/flask_discord/client.py +++ b/flask_discord/client.py @@ -35,7 +35,7 @@ class DiscordOAuth2Session(_http.DiscordOAuth2HttpClient): scope = scope or request.args.get("scope", str()).split() or configs.DEFAULT_SCOPES discord_session = self._make_session(scope=scope) authorization_url, state = discord_session.authorization_url(configs.AUTHORIZATION_BASE_URL) - session["discord_oauth2_state"] = state + session["DISCORD_OAUTH2_STATE"] = state return redirect(authorization_url) def callback(self): @@ -53,7 +53,7 @@ class DiscordOAuth2Session(_http.DiscordOAuth2HttpClient): client_secret=self.client_secret, authorization_response=request.url ) - session["discord_oauth2_token"] = token + session["DISCORD_OAUTH2_TOKEN"] = token def revoke(self): """This method clears current discord token, state and all session data from flask